-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIRCSTORE-539: added new request.item fields and db indexing into request schema #498
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that new fields are getting added in request should the interface "id": "request-storage",
"version": "6.1", be bumped up ?
Are these fields mandatory or optional ?
ramls/request.json
Outdated
}, | ||
"itemEffectiveLocationId": { | ||
"description": "Item's effective location", | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test methods for these new additions in request schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed:=> 9a80571
ramls/request.json
Outdated
}, | ||
"retrievalServicePointId": { | ||
"description": "Item's location primary service point", | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed:=> 9a80571
Quality Gate passedIssues Measures |
https://folio-org.atlassian.net/browse/CIRCSTORE-539