Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCSTORE-539: added new request.item fields and db indexing into request schema #498

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kapil-epam
Copy link
Contributor

Copy link

@gurleenkaurbp gurleenkaurbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that new fields are getting added in request should the interface "id": "request-storage",
"version": "6.1", be bumped up ?
Are these fields mandatory or optional ?

},
"itemEffectiveLocationId": {
"description": "Item's effective location",
"type": "string"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test methods for these new additions in request schema.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed:=> 9a80571

},
"retrievalServicePointId": {
"description": "Item's location primary service point",
"type": "string"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed:=> 9a80571

Copy link

sonarcloud bot commented Dec 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants