CIRCSTORE-539: added new request.item fields and db indexing into request schema #498
+111
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapil-epam
requested review from
gurleenkaurbp,
Vignesh-kalyanasundaram,
AntonAntonich and
alexanderkurash
alexanderkurash
approved these changes
Dec 4, 2024
ramls/request.json
Outdated
| }, | ||
| "itemEffectiveLocationId": { | ||
| "description": "Item's effective location", | ||
| "type": "string" |
There was a problem hiding this comment.
Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"
There was a problem hiding this comment.
Please add test methods for these new additions in request schema.
ramls/request.json
Outdated
| }, | ||
| "retrievalServicePointId": { | ||
| "description": "Item's location primary service point", | ||
| "type": "string" |
There was a problem hiding this comment.
Should there be a pattern or $ref attributes for the ID's ? for e.g. "$ref": "raml-util/schemas/uuid.schema"
|
gurleenkaurbp
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/CIRCSTORE-539